refactor(comments,downloads): pass the request globals explicitly
Johncms\Comments took its sub-action and page offset through $mod and $start globals,
which the four calling controllers set right before constructing it. Both are now keys of
the parameter array Comments already accepts, and the class casts the offset itself — it is
interpolated into a LIMIT clause, so that safety used to rest on all four callers
remembering to cast.
- The same controllers read $_REQUEST['page'] and $_GET['start'] directly; they now read
the request. A page number arriving in the body no longer counts, only the query string.
- $GLOBALS['old'], the "new file" threshold of the downloads module, is gone: FilePresenter
derives it from FilePresenter::NEW_FILE_PERIOD. This fixes the mark on eight of the ten
pages using the presenter — only two set the global, everywhere else the fallback of 0
made every file new.
- CommentsPageTest covers the four pages as far as the harness allows: they sit behind
preconditions a guest cannot satisfy, so it asserts they never answer 5xx and checks the
full page only when the stand serves one.
which the four calling controllers set right before constructing it. Both are now keys of
the parameter array Comments already accepts, and the class casts the offset itself — it is
interpolated into a LIMIT clause, so that safety used to rest on all four callers
remembering to cast.
- The same controllers read $_REQUEST['page'] and $_GET['start'] directly; they now read
the request. A page number arriving in the body no longer counts, only the query string.
- $GLOBALS['old'], the "new file" threshold of the downloads module, is gone: FilePresenter
derives it from FilePresenter::NEW_FILE_PERIOD. This fixes the mark on eight of the ten
pages using the presenter — only two set the global, everywhere else the fallback of 0
made every file new.
- CommentsPageTest covers the four pages as far as the harness allows: they sit behind
preconditions a guest cannot satisfy, so it asserts they never answer 5xx and checks the
full page only when the stand serves one.